[DLCov] Move DebugLoc coverage macro to llvm-config.h#137787
Merged
[DLCov] Move DebugLoc coverage macro to llvm-config.h#137787
Conversation
llvmbot
added
cmake
rscottmanley
approved these changes
Apr 29, 2025
Contributor
rscottmanley
left a comment
rscottmanley
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/14115 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2817 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/5529 Here is the relevant piece of the build log for the reference |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
This patch follows the reversion of llvm#107279, which caused errors by including `llvm/Config/config.h` in a public header. In order to reapply that patch, this PR moves the definition of the config option to the `llvm-config.h` header instead, so that it can be used publicly. This patch also adds `LLVM_` as a prefix to the define, since it is now in a public header.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
This has been defined in llvm#137787 and affects in llvmorg-21-init-10310-g92195f6fc873 (llvm#137787).
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
This patch follows the reversion of llvm#107279, which caused errors by including `llvm/Config/config.h` in a public header. In order to reapply that patch, this PR moves the definition of the config option to the `llvm-config.h` header instead, so that it can be used publicly. This patch also adds `LLVM_` as a prefix to the define, since it is now in a public header.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
This has been defined in llvm#137787 and affects in llvmorg-21-init-10310-g92195f6fc873 (llvm#137787).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch follows the reversion of #107279, which caused errors by including
llvm/Config/config.hin a public header. In order to reapply that patch, this PR moves the definition of the config option to thellvm-config.hheader instead, so that it can be used publicly. This patch also addsLLVM_as a prefix to the define, since it is now in a public header.